Use tcp on port 3000 for puma when nginx socket is empty #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current dev setup uses nginx to forward requests to CC. `devenv.sh` script sets the nginx_socket to empty string as socket communication can be problematic depending on the OS and Docker setup. In this case Thin would open a tcp connection to port 3000. This change does the same for Puma.
kathap
approved these changes
Aug 26, 2024
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Aug 26, 2024
Changes in cloud_controller_ng:
- Use tcp on port 3000 for puma when nginx socket is empty
PR: cloudfoundry/cloud_controller_ng#3939
Author: Johannes Haass <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current dev setup uses nginx to forward requests to CC.
devenv.shscript sets the nginx_socket to empty string as socket communication can be problematic depending on the OS and Docker setup. In this case Thin would open a tcp connection to port 3000. This change does the same for Puma.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests