Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add last_status_change to deployments object #3881

Merged
merged 1 commit into from
Jul 16, 2024
Merged

Conversation

joaopapereira
Copy link
Contributor

@joaopapereira joaopapereira commented Jul 11, 2024

Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:

  • A short explanation of the proposed change:

Add a timestamp for the last time that a status changed on a deployment

  • An explanation of the use cases your change solves

This will help developers identify how long a Canary Deployment has been in the PAUSED state.

@sethboyles sethboyles force-pushed the last_status_change branch 2 times, most recently from 130df5d to a632018 Compare July 11, 2024 21:21
* indicates last time status.reason or status.value was updated
* status_updated_at column is set to updated_at for exisiting deployments. Unfortunately updated_at is nullable, so those with null updated_at (unclear if this is a real scenario) will have status_updated_at set to the current time

Co-authored-by: Joao Pereira <[email protected]>
Co-authored-by: Seth Boyles <[email protected]>
Copy link
Contributor

@Samze Samze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethboyles sethboyles merged commit c3ab524 into main Jul 16, 2024
15 checks passed
@moleske moleske deleted the last_status_change branch July 16, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants