Wrong app instance state returned by process stats endpoint during graceful shutdown #3834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kathap
force-pushed
the
return-state-STOPPING-for-processes-that-are-in-graceful-shutdown
branch
from
ae44b42
to
e12855e
Compare
kathap
force-pushed
the
return-state-STOPPING-for-processes-that-are-in-graceful-shutdown
branch
from
e5f1bb2
to
dbf0b61
Compare
…aceful shutdown After stopping an app, cloud controller will return state STOPPING (instead of DOWN) when calling GET /v3/apps/:guid/processes/:type/stats as long as the app is still in graceful shutdown period and there exists still an actual LRP
kathap
force-pushed
the
return-state-STOPPING-for-processes-that-are-in-graceful-shutdown
branch
from
dbf0b61
to
40cbd19
Compare
moleske
deleted the
return-state-STOPPING-for-processes-that-are-in-graceful-shutdown
branch
This was referenced Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change solves issue #3780.
After stopping an app, cloud controller immediately returns state
DOWNwhen callingGET /v3/apps/:guid/processes/:type/statseven if the app is still in graceful shutdown period. The goal is to not simply to reportDOWNfor an app instance when the desired LRP is not found but it should request the actual LRP additionally to determine the instance state.A short explanation of the proposed change:
If no running instance is found, instead of just returning state
DOWN, now there is a check for the actual LRP state and if there is an actual LRP, state will be set toSTOPPING.An explanation of the use cases your change solves
After stopping an app, cloud controller will return state
STOPPINGwhen callingGET /v3/apps/:guid/processes/:type/statsas long as the app is still in graceful shutdown period and there exists still an actual LRP.I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests