Ensure that delayed_job workers handle SIGQUIT
#3183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a monkey patches to delayed_job workers to gracefully shutdown in case of a `QUIT` signal. So far delayed_job only considered `INT` & `TERM` signals for graceful shutdown. This might become obsolete once the following change is merged into delayed_job. See collectiveidea/delayed_job#900 To ensure that a version bump of delayed_job does not break the monkey patch a test will fail in case the version number changes. In case of a version bump it needs to be manually verified if the monkey patch still works. Co-authored-by: Philipp Thun <[email protected]> Co-authored-by: Sven Krieger <[email protected]> Co-authored-by: Johannes Haass <[email protected]>
philippthun
approved these changes
Feb 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a monkey patches to delayed_job workers to gracefully shutdown in case of a
QUITsignal. So far delayed_job only considersINT&TERMsignals for graceful shutdown.This might become obsolete once the following change is merged into delayed_job: collectiveidea/delayed_job#900
To ensure that a version bump of delayed_job does not break the monkey patch a test will fail in case the version number changes. In case of a version bump it needs to be manually verified if the monkey patch is still working.
Co-authored-by: Philipp Thun [email protected]
Co-authored-by: Sven Krieger [email protected]
Co-authored-by: Johannes Haass [email protected]
Thanks for contributing to cloud_controller_ng. To speed up the process of reviewing your pull request please provide us with:
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests