chore: stop checking go version in Makefile #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before Go 1.21: - The go directive was advisory only; now it is a mandatory requirement - The go directive didn't allow specifying patch versions So, by specifying the patch version in go.mod: - Noone can unknowingly test, run or build this project using an older version of go - The required Go toolchain can be downloaded automatically Therefore, checking the current go version in Makefile is no longer needed.
blgm
approved these changes
Feb 12, 2024
There was a problem hiding this comment.
Using version checking built into Go is much better than using our own. Thanks @fnaranjo-vmw!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#187027977
Before Go 1.21:
So, by specifying the patch version in go.mod:
Therefore, checking the current go version in Makefile is no longer needed.
Checklist: