Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(csb): csb update command supports upgrades enabled #899

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

pivotal-marcela-campo
Copy link
Member

Checklist:

* [ ] Have you added or updated tests to validate the changed functionality?
* [ ] Have you added Release Notes in the docs repositories?

Command was failing when upgrades enabled as we were not passing
in maintenance info version.
@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186442219

The labels on this github issue will be updated when the story is started.

@pivotal-marcela-campo pivotal-marcela-campo changed the title Csb update command supports upgrades chore(docs): csb update command supports upgrades Nov 9, 2023
@pivotal-marcela-campo pivotal-marcela-campo changed the title chore(docs): csb update command supports upgrades chore(csb): csb update command supports upgrades Nov 9, 2023
@pivotal-marcela-campo pivotal-marcela-campo changed the title chore(csb): csb update command supports upgrades chore(csb): csb update command supports upgrades enabled Nov 9, 2023
Copy link
Contributor

@zucchinidev zucchinidev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a suggestion, but feel free to ignore it

internal/local/update_service.go Outdated Show resolved Hide resolved
@pivotal-marcela-campo pivotal-marcela-campo merged commit 28d7aeb into main Nov 9, 2023
6 checks passed
@pivotal-marcela-campo pivotal-marcela-campo deleted the csb_update_command_supports_upgrades branch March 22, 2024 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants