Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pak init to include usable GUIDs in the template #894

Merged
merged 1 commit into from
Nov 8, 2023

Conversation

jhvhs
Copy link
Member

@jhvhs jhvhs commented Nov 7, 2023

Previously, the newly created brokerpak had 00000000-0000-0000-0000-000000000000 as the service GUID, and
00000000-0000-0000-0000-000000000001 as the plan GUID. This would require the author to re-generate the above values. The probability of GUIDs clashing in this case is negligible.

Checklist:

  • [~] Have you added or updated tests to validate the changed functionality?
  • [~] Have you added Release Notes in the docs repositories?
  • Have you followed the Conventional Commits specification?

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/186427056

The labels on this github issue will be updated when the story is started.

@jhvhs jhvhs force-pushed the pak-init-with-real-guid branch from 08f5bb4 to 034c634 Compare November 7, 2023 17:52
Copy link
Member

@pivotal-marcela-campo pivotal-marcela-campo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@pivotal-marcela-campo pivotal-marcela-campo merged commit 48951e9 into main Nov 8, 2023
6 checks passed
@jhvhs jhvhs deleted the pak-init-with-real-guid branch December 11, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

3 participants