chore: physically delete records from the database on #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprovision/unbind Records where being soft-deleted or not even soft-deleted from the database on deprovision and unbind. The terraform_deployments table (which was not even being soft-deleted) would accumulate thousands of records over time, making consistency checks very slow and causing cloud foundry to time out on app start up. Although we could work on changing the way the checks are performed, the broker doesn't have any uses for these soft-deleted or old records once the operation has completed successfully. Hence there is no real use at the moment in keeping this data in the database and take over space and affect performance. [#186230750](https://www.pivotaltracker.com/story/show/186230750)
blgm
approved these changes
Nov 1, 2023
There was a problem hiding this comment.
Looks good. An improvement for the future would be to use actual relationships with the data so that we can make use of the database doing a cascade delete. It feels like we are writing code here that's already implemented in the database, and I think that's the right thing to do in the short term, but in the long term we can refactor and reduce the amount of code that we need to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
deprovision/unbind
Records where being soft-deleted or not even soft-deleted from the database on deprovision and unbind.
The terraform_deployments table (which was not even being soft-deleted) would accumulate thousands of records over time, making consistency checks very slow and causing cloud foundry to time out on app start up. Although we could work on changing the way the checks are performed, the broker doesn't have any uses for these soft-deleted or old records once the operation has completed successfully. Hence there is no real use at the moment in keeping this data in the database and take over space and affect performance.
#186230750
Checklist: