fix: allow lock file path to be set via config file #1118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blgm
force-pushed
the
feat_enabling_lock_files
branch
from
98b96d6 to
b73c14d
Compare
- Renames the environment variable to have prefix CSB rather than GCP. CSB = Cloud Service Broker GCP = Google Service Broker Since this is a fork of a Google project we inherit some GSB variables, but it's an anti-pattern to add more. - Moved the viper definition of the lockfiledir entirely into storage.go. This is a tradeoff because there's something nice about defining all the config in serve.go, but the downside is complexity and accessing the value without using the constant for it (to avoid a circular dependency)
Fixed a staticcheck warning
blgm
force-pushed
the
feat_enabling_lock_files
branch
from
b73c14d to
fd6a4c1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.