Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: updates to allow #1102 to be merged #1114

Merged
merged 2 commits into from
Oct 7, 2024
Merged

test: updates to allow #1102 to be merged #1114

merged 2 commits into from
Oct 7, 2024

Conversation

blgm
Copy link
Member

@blgm blgm commented Oct 7, 2024

These are some changes to tests that when merged with PR #1102 will hopefully allow the tests to continue working.

blgm and others added 2 commits October 7, 2024 15:24
These are some changes to tests that when merged with PR #1102 will hopefully allow the tests to continue working.
@blgm blgm merged commit f95bde1 into main Oct 7, 2024
8 checks passed
@blgm blgm deleted the testup branch October 7, 2024 14:36
@kanngiesser
Copy link
Contributor

Thank you @blgm.

I think the tests uncovered an actual problem, though: Values which are returned by the function NewWorkspace changed with #1102. Namely, the function does not return proper go zero-values in case function inputs are empty or nil.

I proposed #1115 to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants