Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix errors found when updating the static check library #1075

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

zucchinidev
Copy link
Contributor

Checklist:

  • Have you added or updated tests to validate the changed functionality?
  • Have you added Release Notes in the docs repositories?
  • Have you followed the Conventional Commits specification?

@zucchinidev zucchinidev force-pushed the static_check_failure branch from c01809d to fa43cde Compare August 21, 2024 21:22
@zucchinidev zucchinidev merged commit 4c35683 into main Aug 22, 2024
8 checks passed
@zucchinidev zucchinidev deleted the static_check_failure branch August 22, 2024 09:57
ifindlay-cci pushed a commit that referenced this pull request Aug 27, 2024
* chore: manual update tools to fix errors after staticcheck is applied

* chore: printf without parameters is not valid

[#187876023](https://www.pivotaltracker.com/story/show/187876023)

* chore: omit redundant nil check on slice when checking its length

---------

Co-authored-by: Felisia Martini <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

2 participants