Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update inno setup x64 flag to x64compatible #3005

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

weresch
Copy link
Contributor

@weresch weresch commented Jul 9, 2024

Description of the Change

Inno Setup is used to create installers for release, and it no longer supports the ia64 flag and recommends x64compatible instead. See https://jrsoftware.org/ishelp/index.php?topic=setup_architecturesinstallin64bitmode

Why Is This PR Valuable?

Removes an error from building the release

How Urgent Is The Change?

Needed before next release

Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh gururajsh merged commit fbc669a into cloudfoundry:v8 Jul 9, 2024
12 of 13 checks passed
@weresch weresch deleted the v8-x64compatible branch July 9, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants