Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove custom linter #2921

Merged
merged 1 commit into from
May 17, 2024
Merged

Conversation

Samze
Copy link
Contributor

@Samze Samze commented May 14, 2024

Description of the Change

There appears to be have been a custom linter introduced a long time ago, this is currently failing when running make all with:

....
Running custom linters...
bash -c "go run bin/style/main.go api util"
api/shared/wrap_for_cf_on_k8s.go +99 type declaration certRoundTripper defined after a function declaration
api/shared/wrap_for_cf_on_k8s.go +104 method certRoundTripper.RoundTrip defined after function getCert
exit status 1
make: *** [custom-lint] Error 1

Instead of fixing the custom linter, lets just remove it and rely on golangci-lint

Why Is This PR Valuable?

Allows developers to do git clone && make on the repo.

How Urgent Is The Change?

Not urgent

Copy link
Contributor

@joaopapereira joaopapereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good.
The only non-blocking question is if we want to find a linter that checks if we use a function before we define it. I am ok with not adding that check.

@Samze
Copy link
Contributor Author

Samze commented May 15, 2024

The change looks good. The only non-blocking question is if we want to find a linter that checks if we use a function before we define it. I am ok with not adding that check.

Yeah, since unlike some interpreted languages golang has compile checks for functions and ordering doesn't matter, I'd personally be ok with not having this check.

Copy link
Member

@gururajsh gururajsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gururajsh gururajsh merged commit 1c52a87 into cloudfoundry:main May 17, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants