Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add move-route command to cf cli (#2302) #2307

Merged
merged 1 commit into from
Aug 24, 2022
Merged

feat: Add move-route command to cf cli (#2302) #2307

merged 1 commit into from
Aug 24, 2022

Conversation

gururajsh
Copy link
Member

  • feat: Add transfer-route-owner command to cf cli

Co-authored-by: Shwetha Gururaj [email protected]

  • feat: update repository variable. Update workflow action

  • fix: remove windows 2016, swap to windows latest. Fix relative file path

  • chore: windows values

  • chore: swap to Rel instead of join

  • chore: main dir

  • chore: join on current dir

  • chore: clean path first

  • chore: try from slash

  • chore: remove dot syntax

  • chore: swap to move-route

Co-authored-by: Shwetha Gururaj [email protected]

  • chore: windows tests again

  • chore: remove test println

  • chore: update path to /relationships/space from transferowner

Co-authored-by: Shwetha Gururaj [email protected]

  • Change display text

  • Remove focus

  • Fix typo

  • Send non-array data in requestBody

  • Change message ordering

  • Create shared domain instead of private

Co-authored-by: Shwetha Gururaj [email protected]

Thank you for contributing to the CF CLI! Please read the following:

  • Please make sure you have implemented changes in line with the contributing guidelines
  • We're not allowed to accept any PRs without a signed CLA, no matter how small.
    If your contribution falls under a company CLA but your membership is not public, expect delays while we confirm.
  • All new code requires tests to protect against regressions.
  • Contributions must be made against the appropriate branch. See the contributing guidelines
  • Contributions must conform to our style guide. Please reach out to us if you have questions.

Does this PR modify CLI v6, CLI v7, or CLI v8?

Please see the contribution doc above or review Architecture Guide.

Description of the Change

We must be able to understand the design of your change from this description.
Keep in mind that the maintainer reviewing this PR may not be familiar with or
have worked with the code here recently, so please walk us through the concepts.

Why Is This PR Valuable?

What benefits will be realized by the code change? What users would want this change? What user need is this change addressing?

Why Should This Be In Core?

Explain why this functionality should be in the cf CLI, as opposed to a plugin.

Applicable Issues

List any applicable Github Issues here

How Urgent Is The Change?

Is the change urgent? If so, explain why it is time-sensitive.

Other Relevant Parties

Who else is affected by the change?

* feat: Add transfer-route-owner command to cf cli

Co-authored-by: Shwetha Gururaj <[email protected]>

* feat: update repository variable. Update workflow action

* fix: remove windows 2016, swap to windows latest. Fix relative file path

* chore: windows values

* chore: swap to Rel instead of join

* chore: main dir

* chore: join on current dir

* chore: clean path first

* chore: try from slash

* chore: remove dot syntax

* chore: swap to move-route

Co-authored-by: Shwetha Gururaj <[email protected]>

* chore: windows tests again

* chore: remove test println

* chore: update path to /relationships/space from transferowner

Co-authored-by: Shwetha Gururaj <[email protected]>

* Change display text

* Remove focus

* Fix typo

* Send non-array data in requestBody

* Change message ordering

* Create shared domain instead of private

Co-authored-by: Shwetha Gururaj <[email protected]>
@gururajsh gururajsh merged commit ac80d76 into v8 Aug 24, 2022
@gururajsh gururajsh deleted the tas-e-259 branch August 24, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants