Fix selfcontained tests failing due to /whoami #2266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Authored-by: Matt Royal <[email protected]>
gururajsh
pushed a commit
that referenced
this pull request
Mar 18, 2022
Authored-by: Matt Royal <[email protected]>
gururajsh
pushed a commit
that referenced
this pull request
May 17, 2022
Authored-by: Matt Royal <[email protected]>
gururajsh
added a commit
that referenced
this pull request
May 17, 2022
This reverts commit 9e316e2.
gururajsh
added a commit
that referenced
this pull request
May 17, 2022
This reverts commit 9e316e2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Does this PR modify CLI v6, CLI v7, or CLI v8?
This modifies CLI v8. The same changes may be necessary for v9 as well.
Description of the Change
The tests under integration/v7/selfcontained were failing due to a missing stub for the GET /whoami endpoint. This commit adds that stub so that the existing tests will pass.
Why Is This PR Valuable?
See above
Why Should This Be In Core?
See above
Applicable Issues
N/A
How Urgent Is The Change?
Not urgent, but if you intend to run the selfcontained tests in your pipeline then this will be necessary to make them green.
Other Relevant Parties
Who else is affected by the change?
@gcapizzi @kieron-dev