Skip to content

Commit

Permalink
Replace deprecated json_pure with json
Browse files Browse the repository at this point in the history
Per the following warning printed when running specs:

> `json_pure` is deprecated and has no effect, just use `json`

Co-authored-by: Brian Upton <[email protected]>
  • Loading branch information
aramprice and ystros committed Nov 15, 2024
1 parent 5e95ffb commit 9fcf258
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 6 deletions.
5 changes: 1 addition & 4 deletions cf-uaa-lib.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,7 @@ Gem::Specification.new do |s|
s.require_paths = ['lib']

# dependencies
s.add_dependency 'multi_json', '>= 1.12.1', '< 1.16'

This comment has been minimized.

Copy link
@coolgang123

coolgang123 Nov 15, 2024

Contributor

why remove multi_json as well? I was looking at the commit history and saw that it was explicitly added again here: dbc4249

s.add_dependency 'json_pure', '~>2.7'
s.add_dependency 'json', '~>2.7'
s.add_dependency 'httpclient', '~> 2.8', '>= 2.8.2.4'
s.add_dependency 'addressable', '~> 2.8', '>= 2.8.0'

Expand All @@ -42,7 +41,5 @@ Gem::Specification.new do |s|
s.add_development_dependency 'simplecov', '~> 0.22.0'
s.add_development_dependency 'simplecov-rcov', '~> 0.3.0'
s.add_development_dependency 'ci_reporter', '>= 1.9.2', '~> 2.0'
s.add_development_dependency 'json_pure', '~>2.7'
s.add_development_dependency 'ci_reporter_rspec', '~> 1.0'

end
4 changes: 2 additions & 2 deletions lib/uaa/util.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@
# subcomponent's license, as noted in the LICENSE file.
#++

require 'json/pure'
require "base64"
require 'json'
require 'base64'
require 'logger'
require 'uri'

Expand Down

0 comments on commit 9fcf258

Please sign in to comment.