Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make comma delimited ASG tests off by default #1139

Merged

Conversation

geofffranks
Copy link
Contributor

Are you submitting this PR against the develop branch?

Yes

What is this change about?

Fixes test failures related to comma delimited ASGs since that feature is opt-in at a bosh manifest level.

Please provide contextual information.

What version of cf-deployment have you run this cf-acceptance-test change against?

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

If you are introducing a new acceptance test, what is your rationale for including it CATs rather than your own acceptance test suite?

Nope

How many more (or fewer) seconds of runtime will this change introduce to CATs?

None

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

Unblocks cf-acceptance-tests CI

Tag your pair, your PM, and/or team!

@ctlong

Copy link

linux-foundation-easycla bot commented May 20, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: geofffranks / name: Geoff Franks (6c549e0)

…nto a feature in the CCNG job

Signed-off-by: Geoff Franks <[email protected]>
@geofffranks geofffranks force-pushed the comma-delimit-tests-off-by-default branch from 56daa9d to 6c549e0 Compare May 20, 2024 21:02
@ctlong ctlong merged commit d93638e into cloudfoundry:develop May 20, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants