Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service plan uniqueness #1086

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Service plan uniqueness #1086

merged 2 commits into from
Mar 7, 2024

Conversation

johha
Copy link
Contributor

@johha johha commented Mar 7, 2024

Are you submitting this PR against the develop branch?

👍

What is this change about?

A cc bug caused duplicated service plans in the response leading to errors e.g. during cf create-service.
This change extends the existing service plan tests to ensure that the results are unique for regular users.
To reduce code duplication the enable-service-access part was moved into a BeforeEach.

Please provide contextual information.

What version of cf-deployment have you run this cf-acceptance-test change against?

v39.3.0

Please check all that apply for this PR:

  • introduces a new test --- Are you sure everyone should be running this test?
  • changes an existing test
  • requires an update to a CATs integration-config

Did you update the README as appropriate for this change?

  • YES
  • N/A

How many more (or fewer) seconds of runtime will this change introduce to CATs?

N/A

What is the level of urgency for publishing this change?

  • Urgent - unblocks current or future work
  • Slightly Less than Urgent

A cc bug caused duplicated service plans in the response leading to
error e.g. during `cf create-service`.

This change extends the existing service plan tests to ensure that the
results are unique for regular users.

References:
- cloudfoundry/cloud_controller_ng#3648
- cloudfoundry/cli#2792
@johha johha marked this pull request as ready for review March 7, 2024 08:51
@johha johha changed the title Service plans Service plan uniqueness Mar 7, 2024
@johha johha merged commit 04dd2a5 into develop Mar 7, 2024
3 checks passed
@johha johha deleted the service-plans branch March 7, 2024 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants