Run stack_check after DB migrations and seeds #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running the stack_check before the initial DB setup fails, as it waits for the database schema to be current (Sequel::Migrator.is_current?).
Samze
approved these changes
Aug 7, 2024
Samze
added a commit
that referenced
this pull request
Aug 8, 2024
This reverts commit f445c39. We can now run the stack checker before migrations as per cloudfoundry/cloud_controller_ng#3925. This is an improvement as we want to fail the stack checker before any migrations have run so that we are not in a state where migrations have run but the deployment has failed Co-authored-by: Sam Gunaratne <[email protected]>
Samze
added a commit
that referenced
this pull request
Aug 14, 2024
This reverts commit f445c39. We can now run the stack checker before migrations as per cloudfoundry/cloud_controller_ng#3925. This is an improvement as we want to fail the stack checker before any migrations have run so that we are not in a state where migrations have run but the deployment has failed Co-authored-by: Sam Gunaratne <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running the
stack_checkbefore the initial DB setup fails, as it waits for the database schema to be current (Sequel::Migrator.is_current?).I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite