Allow BBR post unlock to proceed if CC api is remotely available #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the unlock health check failed if any single VM was unhealthy because it used the healthz endpoint over a local route
sethboyles
reviewed
Apr 24, 2023
There was a problem hiding this comment.
Side note, but the way this function can return 0 before resetting minus e is suspect: https://github.com/cloudfoundry/capi-release/pull/311/files#diff-c0db106c51e4e0b0add9487bf8b3753cbd75ac3a11d5a0c3fdfeaadc46598a2cR45
sethboyles
reviewed
Apr 24, 2023
| @@ -17,6 +17,10 @@ source /var/vcap/packages/capi_utils/syslog_utils.sh | |||
| <% (1..(p("cc.jobs.local.number_of_workers"))).each do |index| %> | |||
| monit_start_job cloud_controller_worker_local_<%= index %> | |||
| <% end %> | |||
| wait_for_server_to_become_healthy <%= "localhost:#{p("cc.external_port")}/healthz" %> <%= p("cc.post_bbr_healthcheck_timeout_in_seconds") %> | |||
| sleep 30 | |||
| set +e | |||
There was a problem hiding this comment.
I wonder if this script is even set to -e because #L13 might return 0 after setting +e
sethboyles
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the unlock health check failed if any single VM was unhealthy because it used the healthz endpoint over a local route
Thanks for contributing to the
capi_release. To speed up the process of reviewing your pull request please provide us with:A short explanation of the proposed change:
An explanation of the use cases your change solves
Links to any other associated PRs
I have viewed signed and have submitted the Contributor License Agreement
I have made this pull request to the
developbranchI have run CF Acceptance Tests on bosh lite