Pass existing disk CIDs to CPI in create-env command #664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The create_vm (ref https://bosh.io/docs/cpi-api-v2-method/create-vm/) CPI method takes an optional array of CIDs that feed into the VM placement strategy. The BOSH director sends these along, but the create-env command did not. This commit adds that functionality by reading the disks from the state file. [TPCF-27292] Signed-off-by: Nader Ziada <[email protected]>
xtreme-nitin-ravindran
approved these changes
Oct 3, 2024
rkoster
requested review from
a team,
aramprice and
nader-ziada
and removed request for
a team
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The create_vm (ref https://bosh.io/docs/cpi-api-v2-method/create-vm/) CPI method takes an optional array of CIDs that feed into the VM placement strategy. The BOSH director sends these along, but the create-env command did not. This commit adds that functionality by reading the disks from the state file.