Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release linux arm64 version #617

Merged
merged 1 commit into from
Apr 24, 2023
Merged

release linux arm64 version #617

merged 1 commit into from
Apr 24, 2023

Conversation

gflex
Copy link
Contributor

@gflex gflex commented Mar 30, 2023

add release for linux/arm64
what's missing:

  • homebrew does not support linux on arm64 processors. Hence formula is not updated
  • dockerile for arm64. I'm afraid I'm missing how ci/tasks/create-dockerfile.yml is used for build and if we can provide the target platform as argument.

@beyhan
Copy link
Member

beyhan commented Mar 30, 2023

@rkoster what do you think about this?

@rkoster rkoster requested review from a team, ragaskar and ystros and removed request for a team April 13, 2023 14:42
@rkoster rkoster requested a review from beyhan April 20, 2023 14:43
beyhan
beyhan approved these changes Apr 24, 2023
View reviewed changes
Copy link
Member

@beyhan beyhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regarding the ci/tasks/create-dockerfile.yml it is only consumes the linux amd flavour of the CLI that is why should be fine

@rkoster rkoster merged commit b36ee51 into cloudfoundry:main Apr 24, 2023
@cunnie
Copy link
Member

cunnie commented Apr 26, 2023

Thanks @beyhan — this will help with arm64 Docker images which require the BOSH CLI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beyhan beyhan beyhan approved these changes

@rkoster rkoster rkoster approved these changes

@ragaskar ragaskar Awaiting requested review from ragaskar ragaskar was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

@ystros ystros Awaiting requested review from ystros ystros was automatically assigned from cloudfoundry/wg-foundational-infrastructure-vm-deployment-lifecycle-bosh-approvers

Assignees
No one assigned
Labels
None yet
Projects
Foundational Infrastructure Working Group
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@gflex @beyhan @cunnie @rkoster