Loudly error when failing to make an AMI public #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We published a light stemcell (Jammy 1.406) whose AMI in region `eu-central-1` was not public, causing an error when a user tried to deploy. The problem was we never checked to make sure that our attempt to make the AMI public succeeded. With this commit, we now propagate any errors that occur when attempting to make the AMI we publish public. Signed-off-by: Brian Cunnie <[email protected]> [#184045754] Ensure the aws light stemcell builder catches errors when making AMIs public
jpalermo
requested review from
a team,
aramprice and
nouseforaname
and removed request for
a team
aramprice
approved these changes
Mar 21, 2024
aramprice
reviewed
Mar 21, 2024
driver/copy_ami_driver.go
Outdated
| @@ -128,7 +128,7 @@ func (d *SDKCopyAmiDriver) Create(driverConfig resources.AmiDriverConfig) (resou | |||
|
|
|||
| if driverConfig.Accessibility == resources.PublicAmiAccessibility { | |||
| d.logger.Printf("making AMI: %s public", *amiIDptr) | |||
| ec2Client.ModifyImageAttribute(&ec2.ModifyImageAttributeInput{ //nolint:errcheck | |||
| _, err = ec2Client.ModifyImageAttribute(&ec2.ModifyImageAttributeInput{ //nolint:errcheck | |||
There was a problem hiding this comment.
Is the //nolint:errcheck linting directive still needed?
Signed-off-by: Joseph Palermo <[email protected]> Co-authored-by: Joseph Palermo <[email protected]>
jpalermo
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We published a light stemcell (Jammy 1.406) whose AMI in region
eu-central-1was not public, causing an error when a user tried to deploy.The problem was we never checked to make sure that our attempt to make the AMI public succeeded.
With this commit, we now propagate any errors that occur when attempting to make the AMI we publish public.
Signed-off-by: Brian Cunnie [email protected]
[#184045754] Ensure the aws light stemcell builder catches errors when making AMIs public
The test attempts to make an encrypted snapshot public when copying, which triggers the error, "failed to make AMI 'ami-0957311dac7d2f6fe' public: UnsupportedOperation: Encrypted snapshots can't be shared publicly. Specify another snapshot.\n\tstatus code: 400".