Fix CodeQL scanning #2215
Merged
Fix CodeQL scanning #2215
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
silvestre
force-pushed
the
fix-github-codeql-autobuild
branch
from
66c11b5 to
65fbf28
Compare
- Opt-out of `.tool-version` update by renovate - `make build-all` is required to build all binaries nowadays. - Also we can remove `javascript` scanning with the removal of the Node.js test app.
silvestre
force-pushed
the
fix-github-codeql-autobuild
branch
from
65fbf28 to
4068261
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
silvestre
added
exclude-from-changelog
allow-acceptance-tests
salzmannsusan
approved these changes
Oct 27, 2023
silvestre
added a commit
that referenced
this pull request
Dec 7, 2023
silvestre
added a commit
that referenced
this pull request
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will not have a green CodeQL Go run!
It seems that with #2212 subsequent scans broke.
This is due to the fact that all workflows run on the
app-autoscaler-release-toolsimage and it seems that CodeQL still has issues with Go 1.21: github/codeql#13992This PR reverts to the currently used version in the BOSH release and disables automated updates by Renovate so that we don't get versions skews between the BOSH release and asdf, and with it in the image.
Hopefully by the time the BOSH release updates to a Go 1.21 version CodeQL is fixed.