This repository has been archived by the owner on Oct 22, 2021. It is now read-only.
active_passive_reconciler should validate all pods cross zones #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Team will discuss the issue and PR #17 in our plannings (Every Monday) before merging. |
rohitsakala
approved these changes
Oct 20, 2020
|
It would be great to keep the integration test. Added this story to modify |
manno
suggested changes
Oct 22, 2020
manno
approved these changes
Oct 22, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Let
GetMaxStatefulSetVersionto return all StatefulSet at the Max Version, and then loop through the StatefulSet list and validating pods in these StatefulSets.Motivation and Context
When pods deployed cross AZs, the active passive reconciler only validate pods belongs to one AZ.
If the active pod deployed in another AZ, then the component will be unavaialbe.
#17
Checklist:
Check item if necessary.