Skip to content
This repository has been archived by the owner on Oct 22, 2021. It is now read-only.

Clean up persist output #103

Merged
merged 5 commits into from
Jun 25, 2020
Merged

Clean up persist output #103

merged 5 commits into from
Jun 25, 2020

Conversation

manno
Copy link
Member

@manno manno commented Jun 25, 2020 •
edited
Loading

Mario Manno added 5 commits June 25, 2020 10:56
Extract label merging code from createSecret
f0fe738 
* move some of the logging to the parent function
Remove boolean arg from createSecret func
432204d 
For some background: https://martinfowler.com/bliki/FlagArgument.html
In this case it helped to reduce the number of arguments passed into the
function.
Remove 'secret' prefix from variables
e5ed189 
before:
  `createSecret(secretName,secretData, secretLabels, ...)`
Improve unit tests for persistoutput
a502e7e
Remove duplication from qjob docs
f405a89
@rohitsakala rohitsakala merged commit c47221e into master Jun 25, 2020
@rohitsakala rohitsakala deleted the 172993878-clean-up-persist-output branch June 25, 2020 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rohitsakala rohitsakala rohitsakala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manno @rohitsakala