Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plumb through account ID and Worker ID into asset-worker and router-worker #7844

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

WalshyDev
Copy link
Member

Fixes N/A

plumb through account ID and Worker ID into the asset-worker and router-worker for use in analytics and error reporting.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: analytics/error reporting changes
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: analytics/error reporting changes
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: analytics/error reporting changes

@WalshyDev WalshyDev requested review from a team as code owners January 21, 2025 14:25
Copy link

changeset-bot bot commented Jan 21, 2025

🦋 Changeset detected

Latest commit: 50f5b3d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/workers-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update Miniflare to pass in these CONFIG values (or at least partially if they are available)?

@WalshyDev
Copy link
Member Author

Should we update Miniflare to pass in these CONFIG values (or at least partially if they are available)?

Strictly internal only for analytics/errors - miniflare will never run this path and we don't want it to.

@WalshyDev WalshyDev force-pushed the walshy/plumb-in-account-and-script-ids branch 2 times, most recently from 9ad82ce to 14966e6 Compare January 21, 2025 15:17
@WalshyDev WalshyDev added the blocked Blocked on other work label Jan 21, 2025
Copy link
Contributor

github-actions bot commented Jan 21, 2025

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-wrangler-7844

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7844/npm-package-wrangler-7844

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-wrangler-7844 dev path/to/script.js
Additional artifacts:

cloudflare-workers-bindings-extension:

wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-workers-bindings-extension-7844 -O ./cloudflare-workers-bindings-extension.0.0.0-v39e19933a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v39e19933a.vsix

create-cloudflare:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-create-cloudflare-7844 --no-auto-update

@cloudflare/kv-asset-handler:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-kv-asset-handler-7844

miniflare:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-miniflare-7844

@cloudflare/pages-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-pages-shared-7844

@cloudflare/unenv-preset:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-unenv-preset-7844

@cloudflare/vite-plugin:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-vite-plugin-7844

@cloudflare/vitest-pool-workers:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-vitest-pool-workers-7844

@cloudflare/workers-editor-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-workers-editor-shared-7844

@cloudflare/workers-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-workers-shared-7844

@cloudflare/workflows-shared:

npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-workflows-shared-7844

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241230.2
workerd 1.20241230.0 1.20241230.0
workerd --version 1.20241230.0 2024-12-30

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WalshyDev WalshyDev force-pushed the walshy/plumb-in-account-and-script-ids branch 2 times, most recently from ad7bddf to 7de93d7 Compare January 21, 2025 17:23
@WalshyDev WalshyDev force-pushed the walshy/plumb-in-account-and-script-ids branch from 7de93d7 to 50f5b3d Compare January 21, 2025 19:00
@WalshyDev WalshyDev removed the blocked Blocked on other work label Jan 22, 2025
@WalshyDev WalshyDev merged commit 92ed81e into main Jan 22, 2025
36 checks passed
@WalshyDev WalshyDev deleted the walshy/plumb-in-account-and-script-ids branch January 22, 2025 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants