-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plumb through account ID and Worker ID into asset-worker and router-worker #7844
Conversation
🦋 Changeset detectedLatest commit: 50f5b3d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we update Miniflare to pass in these CONFIG values (or at least partially if they are available)?
Strictly internal only for analytics/errors - miniflare will never run this path and we don't want it to. |
9ad82ce
to
14966e6
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-wrangler-7844 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7844/npm-package-wrangler-7844 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-wrangler-7844 dev path/to/script.js Additional artifacts:cloudflare-workers-bindings-extension: wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-workers-bindings-extension-7844 -O ./cloudflare-workers-bindings-extension.0.0.0-v39e19933a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v39e19933a.vsix create-cloudflare: npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-create-cloudflare-7844 --no-auto-update @cloudflare/kv-asset-handler: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-kv-asset-handler-7844 miniflare: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-miniflare-7844 @cloudflare/pages-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-pages-shared-7844 @cloudflare/unenv-preset: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-unenv-preset-7844 @cloudflare/vite-plugin: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-vite-plugin-7844 @cloudflare/vitest-pool-workers: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-vitest-pool-workers-7844 @cloudflare/workers-editor-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-workers-editor-shared-7844 @cloudflare/workers-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-workers-shared-7844 @cloudflare/workflows-shared: npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12893950421/npm-package-cloudflare-workflows-shared-7844 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
ad7bddf
to
7de93d7
Compare
7de93d7
to
50f5b3d
Compare
Fixes N/A
plumb through account ID and Worker ID into the asset-worker and router-worker for use in analytics and error reporting.