Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "add binding" ui to vscode extension #7591

Merged
merged 5 commits into from
Dec 19, 2024

Conversation

emily-shen
Copy link
Contributor

@emily-shen emily-shen commented Dec 18, 2024

Fixes DEVX-1473


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: will do in a followup (haven't set up CI tests for this yet anyway), has been manually tested
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no relevant e2e's
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: not released yet

Copy link

changeset-bot bot commented Dec 18, 2024

🦋 Changeset detected

Latest commit: d587c30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
cloudflare-workers-bindings-extension Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@emily-shen emily-shen changed the base branch from main to edmundhung/vscode-extension-list-bindings December 18, 2024 18:16
@emily-shen emily-shen force-pushed the emily/add-binding-vscode-ui branch from 3ab6f25 to d475e71 Compare December 19, 2024 11:00
Base automatically changed from edmundhung/vscode-extension-list-bindings to main December 19, 2024 11:09
@emily-shen emily-shen force-pushed the emily/add-binding-vscode-ui branch from d475e71 to fd8a008 Compare December 19, 2024 11:17
@emily-shen emily-shen force-pushed the emily/add-binding-vscode-ui branch from fd8a008 to fba4c24 Compare December 19, 2024 11:18
@emily-shen emily-shen marked this pull request as ready for review December 19, 2024 11:18
@emily-shen emily-shen requested a review from a team as a code owner December 19, 2024 11:18
Copy link
Contributor

github-actions bot commented Dec 19, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-wrangler-7591

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7591/npm-package-wrangler-7591

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-wrangler-7591 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-cloudflare-workers-bindings-extension-7591 -O ./cloudflare-workers-bindings-extension.0.0.0-v5e9bc8874.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v5e9bc8874.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-create-cloudflare-7591 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-cloudflare-kv-asset-handler-7591
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-miniflare-7591
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-cloudflare-pages-shared-7591
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-cloudflare-unenv-preset-7591
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-cloudflare-vitest-pool-workers-7591
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-cloudflare-workers-editor-shared-7591
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-cloudflare-workers-shared-7591
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12413667118/npm-package-cloudflare-workflows-shared-7591

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu
Copy link
Contributor

CarmenPopoviciu commented Dec 19, 2024

@emily-shen why are tests being handled in a follow-up?

@emily-shen
Copy link
Contributor Author

@emily-shen why are tests being handled in a follow-up?

we want to get this out before the LDW, and the extension is not yet released, and the vscode extension testing process if a bit undefined for us still and we can't run them in CI yet :')

@emily-shen emily-shen force-pushed the emily/add-binding-vscode-ui branch from d5e792b to d587c30 Compare December 19, 2024 13:29
@CarmenPopoviciu CarmenPopoviciu merged commit 4ab7ffc into main Dec 19, 2024
29 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the emily/add-binding-vscode-ui branch December 19, 2024 15:00
@CarmenPopoviciu CarmenPopoviciu mentioned this pull request Dec 19, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants