feat: add experimental_readRawConfig() #7573
Conversation
🦋 Changeset detectedLatest commit: 8aecc4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
emily-shen
force-pushed
the
emily/read-only
branch
from
0e561fa to
59e9d03
Compare
| @@ -158,498 +152,20 @@ export function readPagesConfig( | |||
| }; | |||
| } | |||
|
|
|||
| export const readRawConfig = (configPath: string | undefined): RawConfig => { | |||
| export const experimental_readRawConfig = ( | |||
There was a problem hiding this comment.
You need to re-export this on the entry file (src/cli.ts) to expose the API
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-wrangler-7573You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7573/npm-package-wrangler-7573Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-wrangler-7573 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-cloudflare-workers-bindings-extension-7573 -O ./cloudflare-workers-bindings-extension.0.0.0-v33cb3799a.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v33cb3799a.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-create-cloudflare-7573 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-cloudflare-kv-asset-handler-7573npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-miniflare-7573npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-cloudflare-pages-shared-7573npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-cloudflare-unenv-preset-7573npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-cloudflare-vitest-pool-workers-7573npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-cloudflare-workers-editor-shared-7573npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-cloudflare-workers-shared-7573npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12377905261/npm-package-cloudflare-workflows-shared-7573Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
| let result = experimental_readRawConfig({ | ||
| script: "./path/to/index.js", | ||
| }); | ||
| expect(result.rawConfig).toEqual({ |
There was a problem hiding this comment.
nit: should this test result.rawConfig.name only? (the date is not specified in the config, same on l 6083 and l 6054
There was a problem hiding this comment.
the writeWranglerConfig helper provides the default name (test-name) and compat date so I think this is okay :)
There was a problem hiding this comment.
Yep, that's only a nit (= minor comment).
FYI my thinking is that writeWranglerConfig is already tested here and this test would break if it changes behavior while this test is for experimental_readRawConfig() (l6041).
There was a problem hiding this comment.
fair enough :) will fix it in a followup PR!
Fixes DEVX 1423