Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wrangler): update unenv dependency version #7566

Closed
wants to merge 1 commit into from
Closed

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Dec 16, 2024

Updates unenv.

Merge after wrangler is updated to use workerd >= 20241216


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: depending update
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: depending update, no user facing change

This is part 2 of 2 in a stack made with GitButler:

@vicb vicb requested a review from a team as a code owner December 16, 2024 15:56
Copy link

changeset-bot bot commented Dec 16, 2024

🦋 Changeset detected

Latest commit: ee42273

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vicb vicb added the e2e Run e2e tests on a PR label Dec 16, 2024
Copy link
Contributor

github-actions bot commented Dec 16, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-wrangler-7566

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7566/npm-package-wrangler-7566

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-wrangler-7566 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-cloudflare-workers-bindings-extension-7566 -O ./cloudflare-workers-bindings-extension.0.0.0-v3120d6590.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v3120d6590.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-create-cloudflare-7566 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-cloudflare-kv-asset-handler-7566
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-miniflare-7566
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-cloudflare-pages-shared-7566
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-cloudflare-unenv-preset-7566
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-cloudflare-vitest-pool-workers-7566
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-cloudflare-workers-editor-shared-7566
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-cloudflare-workers-shared-7566
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12414690475/npm-package-cloudflare-workflows-shared-7566

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241218.0 1.20241218.0
workerd --version 1.20241218.0 2024-12-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@vicb vicb changed the title chore(wrangler): update unenv dependency version [NEED workerd 20241216] chore(wrangler): update unenv dependency version Dec 17, 2024
Base automatically changed from unenv-up to main December 17, 2024 07:10
@vicb vicb mentioned this pull request Dec 18, 2024
9 tasks
@vicb vicb changed the title [NEED workerd 20241216] chore(wrangler): update unenv dependency version chore(wrangler): update unenv dependency version Dec 19, 2024
Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we add a test to the nodejs-hybrid fixture that shows that we are using the built-in node:dns and that it works?

@vicb
Copy link
Contributor Author

vicb commented Dec 19, 2024

Could we add a test to the nodejs-hybrid fixture that shows that we are using the built-in node:dns and that it works?

That's #7581

I should have merged the PR, the order should have been different if the other PR were not reverted, sorry for the mess.

But as soon as I can merge this PR, I'll rebase 7581 to get it in

@vicb
Copy link
Contributor Author

vicb commented Dec 19, 2024

merged into #7581

@vicb vicb closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants