Add additional metrics #7549
Merged
Add additional metrics #7549
+130
−38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Detect Pages & Workers CI * Filter out default args (e.g. --x-versions, --x-dev-env, and --latest)
🦋 Changeset detectedLatest commit: 0d6ad0c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-wrangler-7549You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7549/npm-package-wrangler-7549Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-wrangler-7549 dev path/to/script.jsAdditional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-cloudflare-workers-bindings-extension-7549 -O ./cloudflare-workers-bindings-extension.0.0.0-v7c7612039.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v7c7612039.vsixnpx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-create-cloudflare-7549 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-cloudflare-kv-asset-handler-7549npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-miniflare-7549npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-cloudflare-pages-shared-7549npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-cloudflare-unenv-preset-7549npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-cloudflare-vitest-pool-workers-7549npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-cloudflare-workers-editor-shared-7549npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-cloudflare-workers-shared-7549npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373101981/npm-package-cloudflare-workflows-shared-7549Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
| @@ -36,6 +36,7 @@ | |||
| "EXPERIMENTAL_MIDDLEWARE", | |||
| "FORMAT_WRANGLER_ERRORS", | |||
| "CF_PAGES", | |||
There was a problem hiding this comment.
I wish we could rename this to PAGES_CI
CarmenPopoviciu
approved these changes
Dec 16, 2024
Merged
vicb
reviewed
Dec 17, 2024
| await runWrangler("docs arg --search 'some search term'"); | ||
|
|
||
| expect(requests.count).toBe(2); | ||
| // Notably, this _doesn't_ include default args (e.g. --x-versions) |
There was a problem hiding this comment.
nit: expect(std.debug).not.toContain(...) ?
vicb
reviewed
Dec 17, 2024
|
|
||
| /** | ||
| * Test whether the process is "interactive". | ||
| * Reasons it may not be interactive: it could be running in CI, | ||
| * or you're piping values from / to another process, etc | ||
| */ | ||
| export default function isInteractive(): boolean { | ||
| if (process.env.CF_PAGES === "1") { | ||
| if (isPagesCI() || isWorkersCI()) { |
There was a problem hiding this comment.
q: without knowing the context I would use CI.isCI(). Maybe add a comment on why it is not used.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands metrics collection to:
argv