Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check If-None-Match before fulfilling preservation cache #7546

Merged

Conversation

GregBrimble
Copy link
Member

@GregBrimble GregBrimble commented Dec 13, 2024

Fixes #000

Before fetching the asset, the client may already have the asset contents cached. Let's check If-None-Match first.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: small change

@GregBrimble GregBrimble requested review from a team as code owners December 13, 2024 17:04
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: 82dcab8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/pages-shared Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 13, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-wrangler-7546

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7546/npm-package-wrangler-7546

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-wrangler-7546 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-cloudflare-workers-bindings-extension-7546 -O ./cloudflare-workers-bindings-extension.0.0.0-v666c281c7.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v666c281c7.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-create-cloudflare-7546 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-cloudflare-kv-asset-handler-7546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-miniflare-7546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-cloudflare-pages-shared-7546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-cloudflare-unenv-preset-7546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-cloudflare-vitest-pool-workers-7546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-cloudflare-workers-editor-shared-7546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-cloudflare-workers-shared-7546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12373506677/npm-package-cloudflare-workflows-shared-7546

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@GregBrimble GregBrimble force-pushed the check-if-none-match-before-fulfilling-preservation-cache branch from 1154c7b to e0e7703 Compare December 13, 2024 17:19
Base automatically changed from cleanup-preservation-cache-v1 to main December 16, 2024 17:23
@GregBrimble GregBrimble added the skip-pr-description-validation Skip validation of the required PR description format label Dec 16, 2024
@CarmenPopoviciu CarmenPopoviciu force-pushed the check-if-none-match-before-fulfilling-preservation-cache branch from e0e7703 to 82dcab8 Compare December 17, 2024 12:58
@CarmenPopoviciu CarmenPopoviciu removed the skip-pr-description-validation Skip validation of the required PR description format label Dec 17, 2024
@CarmenPopoviciu CarmenPopoviciu merged commit 004fd33 into main Dec 19, 2024
34 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the check-if-none-match-before-fulfilling-preservation-cache branch December 19, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants