Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove now-unused asset preservation cache v1 from Pages #7544

Merged
merged 1 commit into from
Dec 16, 2024

Conversation

GregBrimble
Copy link
Member

Asset preservation cache v2 fully superceded v1 since 2024-05-17.


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: no e2e coverage
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal change

@GregBrimble GregBrimble requested review from a team as code owners December 13, 2024 16:30
Copy link

changeset-bot bot commented Dec 13, 2024

🦋 Changeset detected

Latest commit: a37943c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/pages-shared Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@GregBrimble GregBrimble force-pushed the cleanup-preservation-cache-v1 branch from 1ef9061 to a37943c Compare December 13, 2024 16:31
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-wrangler-7544

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7544/npm-package-wrangler-7544

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-wrangler-7544 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-workers-bindings-extension-7544 -O ./cloudflare-workers-bindings-extension.0.0.0-v301470968.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v301470968.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-create-cloudflare-7544 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-kv-asset-handler-7544
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-miniflare-7544
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-pages-shared-7544
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-vitest-pool-workers-7544
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-workers-editor-shared-7544
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-workers-shared-7544
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-workflows-shared-7544

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@@ -674,6 +655,7 @@ export async function generateHandler<
}
if (assetKey) {
const asset = await fetchAsset(assetKey);

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Random new line?

@CarmenPopoviciu CarmenPopoviciu merged commit 77bd9a1 into main Dec 16, 2024
29 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the cleanup-preservation-cache-v1 branch December 16, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants