-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove now-unused asset preservation cache v1 from Pages #7544
Conversation
🦋 Changeset detectedLatest commit: a37943c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
1ef9061
to
a37943c
Compare
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-wrangler-7544 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7544/npm-package-wrangler-7544 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-wrangler-7544 dev path/to/script.js Additional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-workers-bindings-extension-7544 -O ./cloudflare-workers-bindings-extension.0.0.0-v301470968.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-v301470968.vsix npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-create-cloudflare-7544 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-kv-asset-handler-7544 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-miniflare-7544 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-pages-shared-7544 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-vitest-pool-workers-7544 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-workers-editor-shared-7544 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-workers-shared-7544 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12319411245/npm-package-cloudflare-workflows-shared-7544 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@@ -674,6 +655,7 @@ export async function generateHandler< | |||
} | |||
if (assetKey) { | |||
const asset = await fetchAsset(assetKey); | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Random new line?
Asset preservation cache v2 fully superceded v1 since 2024-05-17.