Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide validation around experimental_serve_directly usage #7537

Merged

Conversation

WillTaylorDev
Copy link
Contributor

@WillTaylorDev WillTaylorDev commented Dec 12, 2024

Fixes #0000

Gives guidance on usage of serve_directly in the following cases:

  • (Warning) User worker runs first but no assets binding
  • (Error) User worker runs first but no user worker provided
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: n/a
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: n/a

@WillTaylorDev WillTaylorDev requested a review from a team as a code owner December 12, 2024 19:41
Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 3ce560e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Minor
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 12, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-wrangler-7537

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7537/npm-package-wrangler-7537

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-wrangler-7537 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-workers-bindings-extension-7537 -O ./cloudflare-workers-bindings-extension.0.0.0-va6001af11.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va6001af11.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-create-cloudflare-7537 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-kv-asset-handler-7537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-miniflare-7537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-pages-shared-7537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-unenv-preset-7537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-vitest-pool-workers-7537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-workers-editor-shared-7537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-workers-shared-7537
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-workflows-shared-7537

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@WillTaylorDev WillTaylorDev force-pushed the willtaylor/experimental_serve_directly-validation branch from 25e206b to 469dfb8 Compare December 12, 2024 19:46
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/experimental_serve_directly-validation branch from 1bba8a1 to e224fc2 Compare December 16, 2024 21:29
@WillTaylorDev WillTaylorDev force-pushed the willtaylor/experimental_serve_directly-validation branch 3 times, most recently from c826454 to ab124d9 Compare December 18, 2024 21:22
@CarmenPopoviciu CarmenPopoviciu added the e2e Run e2e tests on a PR label Dec 19, 2024
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you so much @WillTaylorDev for working on this! much amaze 🚀

@CarmenPopoviciu CarmenPopoviciu force-pushed the willtaylor/experimental_serve_directly-validation branch from bd1116d to 95e00b2 Compare December 19, 2024 09:19
@CarmenPopoviciu CarmenPopoviciu requested review from a team as code owners December 19, 2024 09:19
@CarmenPopoviciu CarmenPopoviciu force-pushed the willtaylor/experimental_serve_directly-validation branch from 95e00b2 to ee587cf Compare December 19, 2024 09:22
@CarmenPopoviciu CarmenPopoviciu force-pushed the willtaylor/experimental_serve_directly-validation branch from ee587cf to 3ce560e Compare December 19, 2024 09:23
@CarmenPopoviciu CarmenPopoviciu merged commit 086a6b8 into main Dec 19, 2024
31 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the willtaylor/experimental_serve_directly-validation branch December 19, 2024 10:09
penalosa pushed a commit that referenced this pull request Jan 10, 2025
* Provide validation around experimental_serve_directly usage in dev and deploy

* Update based on PR feedback

* Update packages/wrangler/src/assets.ts

* Update packages/wrangler/src/__tests__/dev.test.ts

* Update packages/wrangler/src/__tests__/deploy.test.ts

* fix

---------

Co-authored-by: Carmen Popoviciu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants