-
Notifications
You must be signed in to change notification settings - Fork 759
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide validation around experimental_serve_directly usage #7537
Provide validation around experimental_serve_directly usage #7537
Conversation
🦋 Changeset detectedLatest commit: 3ce560e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-wrangler-7537 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7537/npm-package-wrangler-7537 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-wrangler-7537 dev path/to/script.js Additional artifacts:wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-workers-bindings-extension-7537 -O ./cloudflare-workers-bindings-extension.0.0.0-va6001af11.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-va6001af11.vsix npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-create-cloudflare-7537 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-kv-asset-handler-7537 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-miniflare-7537 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-pages-shared-7537 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-unenv-preset-7537 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-vitest-pool-workers-7537 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-workers-editor-shared-7537 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-workers-shared-7537 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12409818669/npm-package-cloudflare-workflows-shared-7537 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
25e206b
to
469dfb8
Compare
1bba8a1
to
e224fc2
Compare
c826454
to
ab124d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you so much @WillTaylorDev for working on this! much amaze 🚀
bd1116d
to
95e00b2
Compare
95e00b2
to
ee587cf
Compare
ee587cf
to
3ce560e
Compare
* Provide validation around experimental_serve_directly usage in dev and deploy * Update based on PR feedback * Update packages/wrangler/src/assets.ts * Update packages/wrangler/src/__tests__/dev.test.ts * Update packages/wrangler/src/__tests__/deploy.test.ts * fix --------- Co-authored-by: Carmen Popoviciu <[email protected]>
Fixes #0000
Gives guidance on usage of serve_directly in the following cases: