Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert deployments to createCommand #7499

Merged
merged 10 commits into from
Dec 17, 2024

Conversation

andyjessop
Copy link
Contributor

Fixes #000.

Converts deployments to createCommand.

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because: covered by existing tests
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: internal only

@andyjessop andyjessop added e2e Run e2e tests on a PR no-changeset-required labels Dec 10, 2024
Copy link

changeset-bot bot commented Dec 10, 2024

⚠️ No Changeset found

Latest commit: 03f8f5d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Dec 10, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-wrangler-7499

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7499/npm-package-wrangler-7499

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-wrangler-7499 dev path/to/script.js
Additional artifacts:
wget https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-cloudflare-workers-bindings-extension-7499 -O ./cloudflare-workers-bindings-extension.0.0.0-vd902b11a3.vsix && code --install-extension ./cloudflare-workers-bindings-extension.0.0.0-vd902b11a3.vsix
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-create-cloudflare-7499 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-cloudflare-kv-asset-handler-7499
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-miniflare-7499
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-cloudflare-pages-shared-7499
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-cloudflare-vitest-pool-workers-7499
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-cloudflare-workers-editor-shared-7499
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-cloudflare-workers-shared-7499
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/12369388746/npm-package-cloudflare-workflows-shared-7499

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241205.0
workerd 1.20241205.0 1.20241205.0
workerd --version 1.20241205.0 2024-12-05

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@andyjessop andyjessop force-pushed the aj/convert-deployments-2-to-create-command branch from 4c2ff47 to d37079f Compare December 10, 2024 10:18
@andyjessop andyjessop marked this pull request as ready for review December 10, 2024 10:18
@andyjessop andyjessop requested a review from a team as a code owner December 10, 2024 10:18
@CarmenPopoviciu CarmenPopoviciu force-pushed the aj/convert-deployments-2-to-create-command branch 2 times, most recently from bc40912 to 252b74d Compare December 16, 2024 17:36
@andyjessop andyjessop force-pushed the aj/convert-deployments-2-to-create-command branch from 252b74d to 03f8f5d Compare December 17, 2024 08:45
@CarmenPopoviciu CarmenPopoviciu merged commit a55bc36 into main Dec 17, 2024
31 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the aj/convert-deployments-2-to-create-command branch December 17, 2024 09:34
penalosa pushed a commit that referenced this pull request Jan 10, 2025
* chore: convert deployments to createCommand

kebab case for positional

remove print banner

chore: register namesapce

* chore: add hidden to deployments view

* remove unused imports

* Update packages/wrangler/src/versions/deployments/list.ts

* Update packages/wrangler/src/versions/deployments/list.ts

* Update packages/wrangler/src/versions/deployments/status.ts

* Update packages/wrangler/src/versions/deployments/status.ts

* Update packages/wrangler/src/versions/deployments/status.ts

* Update packages/wrangler/src/versions/deployments/view.ts

* chore: update snapshots

---------

Co-authored-by: Carmen Popoviciu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR no-changeset-required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants