-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Improve readme for devtools package #7138
Conversation
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-wrangler-7138 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7138/npm-package-wrangler-7138 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-wrangler-7138 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-create-cloudflare-7138 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-cloudflare-kv-asset-handler-7138 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-miniflare-7138 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-cloudflare-pages-shared-7138 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-cloudflare-vitest-pool-workers-7138 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-cloudflare-workers-editor-shared-7138 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-cloudflare-workers-shared-7138 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11610637579/npm-package-cloudflare-workflows-shared-7138 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love it! Thanks for preparing all the docs 👍🏼
packages/wrangler-devtools/README.md
Outdated
5. Thorough testing across all integration points | ||
|
||
**For detailed instructions on updating DevTools, please refer to our internal documentation at: | ||
https://wiki.cfdata.org/display/WX/Keeping+DevTools+up-to-date** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure if we should link the internal wiki here. Do we have other examples doing this? How about moving the instructions here and put a github link in the wiki?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, you're absolutely right. Not sure why I put this here. I'll just say to refer to the internal documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there's definitely a couple floating around if you search wiki.cfdata
, should we clean up those...?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeap, I think it makes sense to get rid of those.
Fixes #000.
Improves the documentation surrounding our usage and maintenance of the Chrome DevTools patches.