Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Modify Cloudchamber deployment labels in interactive mode #7124

Merged

Conversation

skepticfx
Copy link
Member

@skepticfx skepticfx commented Oct 30, 2024

Depolyment label modification works as expected in non-interactive mode. However, during interactive mode, we do not add the required labels to the final API Request.

Added labels fixture to modification tests as well.

Fixes CC-4451


  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: Minor UX change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: Minor UX change

@skepticfx skepticfx requested review from a team as code owners October 30, 2024 03:55
Copy link

changeset-bot bot commented Oct 30, 2024

🦋 Changeset detected

Latest commit: e3d48f2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 30, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-wrangler-7124

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7124/npm-package-wrangler-7124

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-wrangler-7124 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-create-cloudflare-7124 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-kv-asset-handler-7124
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-miniflare-7124
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-pages-shared-7124
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-vitest-pool-workers-7124
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-workers-editor-shared-7124
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-workers-shared-7124
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-workflows-shared-7124

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Member

@gpanders gpanders left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just ran into this yesterday, thanks for the fix!

Copy link
Member

@edmundhung edmundhung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need a changeset to trigger a release for wrangler. Can you please add one?

Depolyment label modification works as expected in non-interactive mode. However,
during interactive mode, we do not add the required labels to the final API Request.

Added labels fixture to modification tests as well.
@skepticfx skepticfx force-pushed the nafeez/deployment-labels-interactive branch from c6d5dad to e3d48f2 Compare October 30, 2024 18:42
@edmundhung edmundhung merged commit f8ebdd1 into cloudflare:main Oct 31, 2024
20 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

5 participants