-
Notifications
You must be signed in to change notification settings - Fork 751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Modify Cloudchamber deployment labels in interactive mode #7124
fix: Modify Cloudchamber deployment labels in interactive mode #7124
Conversation
🦋 Changeset detectedLatest commit: e3d48f2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-wrangler-7124 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7124/npm-package-wrangler-7124 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-wrangler-7124 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-create-cloudflare-7124 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-kv-asset-handler-7124 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-miniflare-7124 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-pages-shared-7124 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-vitest-pool-workers-7124 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-workers-editor-shared-7124 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-workers-shared-7124 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11599642358/npm-package-cloudflare-workflows-shared-7124 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just ran into this yesterday, thanks for the fix!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will need a changeset to trigger a release for wrangler. Can you please add one?
Depolyment label modification works as expected in non-interactive mode. However, during interactive mode, we do not add the required labels to the final API Request. Added labels fixture to modification tests as well.
c6d5dad
to
e3d48f2
Compare
Depolyment label modification works as expected in non-interactive mode. However, during interactive mode, we do not add the required labels to the final API Request.
Added labels fixture to modification tests as well.
Fixes CC-4451