Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change trigger command to comply with new endpoint #7067

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

LuisDuarte1
Copy link
Contributor

@LuisDuarte1 LuisDuarte1 commented Oct 23, 2024

Fixes WOR-280

Because the body for the trigger command changed, we also need to change it here. As a consequence we also add an optional --id to let users to optionally customize the new instance ID.

@LuisDuarte1 LuisDuarte1 requested a review from a team as a code owner October 23, 2024 11:09
Copy link

changeset-bot bot commented Oct 23, 2024

🦋 Changeset detected

Latest commit: 0790dbd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 23, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478721900/npm-package-wrangler-7067

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7067/npm-package-wrangler-7067

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478721900/npm-package-wrangler-7067 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478721900/npm-package-create-cloudflare-7067 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478721900/npm-package-cloudflare-kv-asset-handler-7067
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478721900/npm-package-miniflare-7067
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478721900/npm-package-cloudflare-pages-shared-7067
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478721900/npm-package-cloudflare-vitest-pool-workers-7067
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478721900/npm-package-cloudflare-workers-editor-shared-7067
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11478721900/npm-package-cloudflare-workers-shared-7067

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241018.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen emily-shen added the skip-pr-description-validation Skip validation of the required PR description format label Oct 23, 2024
@sidharthachatterjee
Copy link
Contributor

Let's stick to the PR template form henceforth please, we should follow guidelines for each repo @LuisDuarte1

@sidharthachatterjee sidharthachatterjee merged commit 4aa35c5 into main Oct 23, 2024
25 of 26 checks passed
@sidharthachatterjee sidharthachatterjee deleted the lduarte/change-trigger-command branch October 23, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-pr-description-validation Skip validation of the required PR description format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants