Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(create-cloudflare): prompt user to correct the answer if the arg value is invalid #7055

Merged
merged 6 commits into from
Oct 25, 2024

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Oct 22, 2024

Fixes n/a.

Previously, if you provide an invalid project name on the command, c3 will print an error message and crash the CLI immediately:

Screenshot 2024-10-22 at 17 06 25

Now, it will prompt user to correct the answer instead. So it behave consistently as if user provide an invalid project name on the prompt.

Screenshot 2024-10-22 at 17 06 48
  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because: No impact on other parts
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: UX improvement

Copy link

changeset-bot bot commented Oct 22, 2024

🦋 Changeset detected

Latest commit: f846029

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
create-cloudflare Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Oct 22, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-wrangler-7055

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/7055/npm-package-wrangler-7055

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-wrangler-7055 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-create-cloudflare-7055 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-cloudflare-kv-asset-handler-7055
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-miniflare-7055
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-cloudflare-pages-shared-7055
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-cloudflare-vitest-pool-workers-7055
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-cloudflare-workers-editor-shared-7055
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-cloudflare-workers-shared-7055
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11516394359/npm-package-cloudflare-workflows-shared-7055

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241022.0
workerd 1.20241022.0 1.20241022.0
workerd --version 1.20241022.0 2024-10-22

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung force-pushed the edmundhung/DEVX-1441 branch from dad68bb to 99f6665 Compare October 22, 2024 15:53
@edmundhung edmundhung marked this pull request as ready for review October 23, 2024 12:44
@edmundhung edmundhung requested review from a team as code owners October 23, 2024 12:45
@edmundhung edmundhung changed the title feat(create-cloudflare): prompt instead of throw if the arg value is invalid feat(create-cloudflare): prompt user to correct the answer if the arg value is invalid Oct 23, 2024
@edmundhung edmundhung merged commit a034aa1 into main Oct 25, 2024
30 checks passed
@edmundhung edmundhung deleted the edmundhung/DEVX-1441 branch October 25, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants