Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pnpm dedupe #6979

Merged
merged 2 commits into from
Oct 15, 2024
Merged

chore: pnpm dedupe #6979

merged 2 commits into from
Oct 15, 2024

Conversation

emily-shen
Copy link
Contributor

What this PR solves / how to test

Fixes #[insert GH or internal issue number(s)].

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because:

Copy link

changeset-bot bot commented Oct 15, 2024

⚠️ No Changeset found

Latest commit: d618e2e

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@emily-shen emily-shen added the skip-pr-description-validation Skip validation of the required PR description format label Oct 15, 2024
@emily-shen emily-shen requested a review from a team as a code owner October 15, 2024 11:14
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11344903274/npm-package-wrangler-6979

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6979/npm-package-wrangler-6979

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11344903274/npm-package-wrangler-6979 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11344903274/npm-package-create-cloudflare-6979 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11344903274/npm-package-cloudflare-kv-asset-handler-6979
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11344903274/npm-package-miniflare-6979
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11344903274/npm-package-cloudflare-pages-shared-6979
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11344903274/npm-package-cloudflare-vitest-pool-workers-6979
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11344903274/npm-package-cloudflare-workers-editor-shared-6979
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11344903274/npm-package-cloudflare-workers-shared-6979

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241004.0
workerd 1.20241011.1 1.20241011.1
workerd --version 1.20241011.1 2024-10-11

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@emily-shen
Copy link
Contributor Author

emily-shen commented Oct 15, 2024

note: @cloudflare/types (api types) is not up to date (currently fixed to 6.18.4), if we update it then wrangler fails to build due to a legitimate (?) type error

@penalosa
Copy link
Contributor

note: @cloudflare/types (api types) is not up to date (currently fixed to 6.18.4), if we update it then wrangler fails to build due to a legitimate (?) type error

We should probably leave it as is, and focus on moving over to the cloudflare SDK once that's mature enough (it might be by now, it's been a bit since I looked at it)

@emily-shen emily-shen added the e2e Run e2e tests on a PR label Oct 15, 2024
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming tests pass this seems good!

@emily-shen emily-shen merged commit 9711019 into main Oct 15, 2024
28 checks passed
@emily-shen emily-shen deleted the emily/pnpm-nonsense branch October 15, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR skip-pr-description-validation Skip validation of the required PR description format
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants