Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (local) indicator to bindings using local data #6972

Merged
merged 6 commits into from
Oct 21, 2024

Conversation

penalosa
Copy link
Contributor

@penalosa penalosa commented Oct 15, 2024

What this PR solves / how to test

Fixes #6811

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Tests included
    • Tests not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required
    • Not required because:
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Changeset included
    • Changeset not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Documentation not necessary because: small output change

@penalosa penalosa requested a review from a team as a code owner October 15, 2024 09:21
Copy link

changeset-bot bot commented Oct 15, 2024

🦋 Changeset detected

Latest commit: bfe2dce

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@workers-devprod workers-devprod added the e2e Run e2e tests on a PR label Oct 15, 2024
Copy link
Contributor

github-actions bot commented Oct 15, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11439408999/npm-package-wrangler-6972

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6972/npm-package-wrangler-6972

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11439408999/npm-package-wrangler-6972 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11439408999/npm-package-create-cloudflare-6972 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11439408999/npm-package-cloudflare-kv-asset-handler-6972
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11439408999/npm-package-miniflare-6972
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11439408999/npm-package-cloudflare-pages-shared-6972
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11439408999/npm-package-cloudflare-vitest-pool-workers-6972
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11439408999/npm-package-cloudflare-workers-editor-shared-6972
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11439408999/npm-package-cloudflare-workers-shared-6972

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20241011.0
workerd 1.20241018.1 1.20241018.1
workerd --version 1.20241018.1 2024-10-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

packages/wrangler/src/config/index.ts Outdated Show resolved Hide resolved
packages/wrangler/src/dev.tsx Outdated Show resolved Hide resolved
Copy link
Contributor

@andyjessop andyjessop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@penalosa penalosa force-pushed the penalosa/local-mode-indicator branch from c1dcb9f to bfe2dce Compare October 21, 2024 11:45
@penalosa penalosa merged commit c794935 into main Oct 21, 2024
22 checks passed
@penalosa penalosa deleted the penalosa/local-mode-indicator branch October 21, 2024 12:55
@rozenmd
Copy link
Contributor

rozenmd commented Oct 21, 2024

You love to see it 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
e2e Run e2e tests on a PR
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

🚀 Feature Request: It isn't clear that R2 buckets bound in wrangler dev are local
4 participants