-
Notifications
You must be signed in to change notification settings - Fork 756
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle more module declaration cases #6792
Conversation
🦋 Changeset detectedLatest commit: a213c8a The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never seen a TS module declaration with trailing *
like folder/*
but assuming that's fine, LGTM!
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-wrangler-6792 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6792/npm-package-wrangler-6792 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-wrangler-6792 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-create-cloudflare-6792 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-kv-asset-handler-6792 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-miniflare-6792 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-pages-shared-6792 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-vitest-pool-workers-6792 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-workers-editor-shared-6792 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/11110975562/npm-package-cloudflare-workers-shared-6792 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
48e46cb
to
a213c8a
Compare
What this PR solves / how to test
Fixes #6730
Handle more rule glob cases when generating
declare module "..." { }
typesAuthor has addressed the following