fix: disable observability on deploy if not explicitly defined in config #6776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a613f11 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944273668/npm-package-wrangler-6776You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6776/npm-package-wrangler-6776Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944273668/npm-package-wrangler-6776 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944273668/npm-package-create-cloudflare-6776 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944273668/npm-package-cloudflare-kv-asset-handler-6776npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944273668/npm-package-miniflare-6776npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944273668/npm-package-cloudflare-pages-shared-6776npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944273668/npm-package-cloudflare-vitest-pool-workers-6776npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944273668/npm-package-cloudflare-workers-editor-shared-6776npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10944273668/npm-package-cloudflare-workers-shared-6776Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
penalosa
approved these changes
Sep 19, 2024
zebp
force-pushed
the
zeb/observability-disabled-if-missing
branch
from
f7bf04a to
76d4929
Compare
edmundhung
approved these changes
Sep 19, 2024
Changes the deploy behavior deploys using the new versions API to disable observability if it isn't explicitly defined in the user's wrangler.toml.
zebp
force-pushed
the
zeb/observability-disabled-if-missing
branch
from
76d4929 to
a613f11
Compare
Merged
taylorlee
added a commit
that referenced
this pull request
Oct 24, 2024
In addition to logpush and tail_consumers, patch observability settings on version deploy. This still doesn't quite match the behavior of "wrangler deploy", which will disable observability if it is not defined in wrangler.toml (as of #6776), but at least this is more correct for now.
taylorlee
added a commit
that referenced
this pull request
Oct 24, 2024
In addition to logpush and tail_consumers, patch observability settings on version deploy. This still doesn't quite match the behavior of "wrangler deploy", which will disable observability if it is not defined in wrangler.toml (as of #6776), but at least this is more correct for now.
3 tasks
taylorlee
added a commit
that referenced
this pull request
Oct 25, 2024
In addition to logpush and tail_consumers, patch observability settings on version deploy. This still doesn't quite match the behavior of "wrangler deploy", which will disable observability if it is not defined in wrangler.toml (as of #6776), but at least this is more correct for now.
taylorlee
added a commit
that referenced
this pull request
Oct 25, 2024
In addition to logpush and tail_consumers, patch observability settings on version deploy. This still doesn't quite match the behavior of "wrangler deploy", which will disable observability if it is not defined in wrangler.toml (as of #6776), but at least this is more correct for now.
taylorlee
added a commit
that referenced
this pull request
Oct 28, 2024
In addition to logpush and tail_consumers, patch observability settings on version deploy. This still doesn't quite match the behavior of "wrangler deploy", which will disable observability if it is not defined in wrangler.toml (as of #6776), but at least this is more correct for now.
taylorlee
added a commit
that referenced
this pull request
Oct 29, 2024
In addition to logpush and tail_consumers, patch observability settings on version deploy. This still doesn't quite match the behavior of "wrangler deploy", which will disable observability if it is not defined in wrangler.toml (as of #6776), but at least this is more correct for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Changes the deploy behavior deploys using the new versions API to disable observability if it isn't explicitly defined in the user's
wrangler.toml. This behaves differently from howlogpushandtail_consumerswork, where they must be explicitly removed, but we decided that this PR's behavior matches user expectations better.Fixes WO-186
Author has addressed the following