fix: update manifest/eTags on asset file content change #6736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e1de055 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10938198386/npm-package-wrangler-6736You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6736/npm-package-wrangler-6736Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10938198386/npm-package-wrangler-6736 dev path/to/script.jsAdditional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10938198386/npm-package-create-cloudflare-6736 --no-auto-updatenpm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10938198386/npm-package-cloudflare-kv-asset-handler-6736npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10938198386/npm-package-miniflare-6736npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10938198386/npm-package-cloudflare-pages-shared-6736npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10938198386/npm-package-cloudflare-vitest-pool-workers-6736npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10938198386/npm-package-cloudflare-workers-editor-shared-6736npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10938198386/npm-package-cloudflare-workers-shared-6736Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
GregBrimble
approved these changes
Sep 17, 2024
| // This way the 'content hash' still updates on file change, so the eTag also updates, | ||
| // and we don't incorrectly get a 304. | ||
| contentHash: await hashPath( | ||
| encodeFilePath(relativeFilepath, path.sep) + modifiedTime.toString() |
There was a problem hiding this comment.
oh clever! I was going to hash the whole thing à la prod, but this saves an expensive computation!
emily-shen
force-pushed
the
emily/dev-with-etags
branch
from
8eab9f1 to
c21334c
Compare
edmundhung
approved these changes
Sep 18, 2024
CarmenPopoviciu
approved these changes
Sep 18, 2024
edmundhung
reviewed
Sep 19, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR solves / how to test
Fixes WC-2713
Author has addressed the following