-
Notifications
You must be signed in to change notification settings - Fork 760
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
c3: default "do you want to deploy" to no #6626
Conversation
🦋 Changeset detectedLatest commit: 1204248 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704745266/npm-package-wrangler-6626 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6626/npm-package-wrangler-6626 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704745266/npm-package-wrangler-6626 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704745266/npm-package-create-cloudflare-6626 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704745266/npm-package-cloudflare-kv-asset-handler-6626 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704745266/npm-package-miniflare-6626 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704745266/npm-package-cloudflare-pages-shared-6626 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704745266/npm-package-cloudflare-vitest-pool-workers-6626 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704745266/npm-package-cloudflare-workers-editor-shared-6626 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10704745266/npm-package-cloudflare-workers-shared-6626 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nevikashah @lrapoport-cf @edmundhung re: C3 improvements proj
Fixing e2e test (which assumed the default was "yes") |
This PR flips the default to "Do you want to deploy your application" to "No".
Most of our own docs guide users to say "no"
This partial is referenced 34 times across our docs:
➜ rg -c 'c3-post-run-steps' src/content/docs/r2/api/workers/workers-api-usage.mdx:1 src/content/docs/r2/examples/upload-logs-event-notifications.mdx:1 src/content/docs/vectorize/get-started/embeddings.mdx:1 src/content/docs/vectorize/get-started/intro.mdx:1 src/content/docs/kv/get-started.mdx:1 src/content/docs/ai-gateway/tutorials/deploy-aig-worker.mdx:1 src/content/docs/d1/tutorials/build-a-comments-api/index.mdx:1 src/content/docs/workers-ai/get-started/workers-wrangler.mdx:1 src/content/docs/d1/get-started.mdx:1 src/content/docs/workers-ai/tutorials/build-a-retrieval-augmented-generation-ai.mdx:1 src/content/docs/developer-spotlight/tutorials/custom-access-control-for-files.mdx:1 src/content/docs/durable-objects/get-started.mdx:1 src/content/docs/hyperdrive/tutorials/serverless-timeseries-api-with-timescale/index.mdx:1 src/content/docs/browser-rendering/get-started/reuse-sessions.mdx:1 src/content/docs/browser-rendering/get-started/screenshots.mdx:1 src/content/docs/hyperdrive/get-started.mdx:1 src/content/docs/cloudflare-for-platforms/workers-for-platforms/get-started/developing-with-wrangler.mdx:3 src/content/docs/cloudflare-for-platforms/workers-for-platforms/get-started/configuration.mdx:1 src/content/docs/radar/investigate/bgp-anomalies.mdx:1 src/content/docs/learning-paths/workers/get-started/first-worker.mdx:1 src/content/docs/workers/get-started/guide.mdx:1 src/content/docs/cloudflare-one/identity/authorization-cookie/cors.mdx:1 src/content/docs/workers/tutorials/upload-assets-with-r2/index.mdx:1 src/content/docs/workers/tutorials/postgres/index.mdx:1 src/content/docs/workers/tutorials/openai-function-calls-workers/index.mdx:1 src/content/docs/workers/tutorials/build-a-qr-code-generator/index.mdx:1 src/content/docs/workers/tutorials/generate-youtube-thumbnails-with-workers-and-images/index.mdx:1 src/content/docs/workers/tutorials/build-a-jamstack-app/index.mdx:1 src/content/docs/workers/tutorials/connect-to-turso-using-workers/index.mdx:1 src/content/docs/workers/tutorials/github-sms-notifications-using-twilio/index.mdx:1 src/content/docs/workers/tutorials/handle-form-submissions-with-airtable/index.mdx:1 src/content/docs/workers/tutorials/create-finetuned-chatgpt-ai-models-with-r2/index.mdx:1 src/content/docs/queues/tutorials/web-crawler-with-browser-rendering/index.mdx:1 src/content/docs/queues/get-started.mdx:1