-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(quick-edit): disable autosave #6558
Conversation
🦋 Changeset detectedLatest commit: f0cdc4d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-wrangler-6558 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6558/npm-package-wrangler-6558 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-wrangler-6558 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-create-cloudflare-6558 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-kv-asset-handler-6558 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-miniflare-6558 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-pages-shared-6558 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-vitest-pool-workers-6558 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-workers-editor-shared-6558 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10509066936/npm-package-cloudflare-workers-shared-6558 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
@@ -16,6 +16,7 @@ export const onRequest = async ({ | |||
: "Solarflare Light", | |||
"workbench.startupEditor": "none", | |||
"editor.minimap.autohide": true, | |||
"files.autoSave": "off", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was expecting the autosave to be disabled by default and it was enabled by us somewhere. However I couldn't find anywhere we set it to afterDelay
. 🤔
What this PR solves / how to test
Fixes DEVX-1306.
This PR disables the autosave setting in vscode to avoid context reset without explicit user action.
Author has addressed the following