Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: run version upload tests in a temp directory, rather than the wrangler package directory #6547

Merged
merged 1 commit into from
Aug 21, 2024

Conversation

petebacondarwin
Copy link
Contributor

Prior to this, when you run the Wrangler tests you would find a directory (versions-upload-test-worker) and a couple of files (index.js and another.js) keep appearing.

@petebacondarwin petebacondarwin requested a review from a team as a code owner August 21, 2024 13:36
Copy link

changeset-bot bot commented Aug 21, 2024

⚠️ No Changeset found

Latest commit: 4618234

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10491058800/npm-package-wrangler-6547

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6547/npm-package-wrangler-6547

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10491058800/npm-package-wrangler-6547 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10491058800/npm-package-create-cloudflare-6547 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10491058800/npm-package-cloudflare-kv-asset-handler-6547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10491058800/npm-package-miniflare-6547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10491058800/npm-package-cloudflare-pages-shared-6547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10491058800/npm-package-cloudflare-vitest-pool-workers-6547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10491058800/npm-package-cloudflare-workers-editor-shared-6547
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10491058800/npm-package-cloudflare-workers-shared-6547

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.1
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@petebacondarwin petebacondarwin merged commit 090a596 into main Aug 21, 2024
18 checks passed
@petebacondarwin petebacondarwin deleted the do-not-write-test-fixtures-to-workspace branch August 21, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants