-
Notifications
You must be signed in to change notification settings - Fork 757
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(quick-edit): add "search.exclude" support to quick editor #6546
Conversation
🦋 Changeset detectedLatest commit: 796b8f6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
A wrangler prerelease is available for testing. You can install this latest build in your project with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-wrangler-6546 You can reference the automatically updated head of this PR with: npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6546/npm-package-wrangler-6546 Or you can use npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-wrangler-6546 dev path/to/script.js Additional artifacts:npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-create-cloudflare-6546 --no-auto-update npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-kv-asset-handler-6546 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-miniflare-6546 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-pages-shared-6546 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-vitest-pool-workers-6546 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-workers-editor-shared-6546 npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-workers-shared-6546 Note that these links will no longer work once the GitHub Actions artifact expires.
Please ensure constraints are pinned, and |
db7c462
to
2dc09ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good!
ff46d68
to
796b8f6
Compare
What this PR solves / how to test
Fixes DEVX-1384
This PR adds
wrangler.toml
andpackage.json
to thefiles.exclude
setting to reduce user confusions. It also makes these files not searchable anymore by addingsearch.exclude
support, which inherits all glob patterns from thefiles.exclude
setting.Author has addressed the following