Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(quick-edit): add "search.exclude" support to quick editor #6546

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

edmundhung
Copy link
Member

@edmundhung edmundhung commented Aug 21, 2024

What this PR solves / how to test

Fixes DEVX-1384

This PR adds wrangler.toml and package.json to the files.exclude setting to reduce user confusions. It also makes these files not searchable anymore by adding search.exclude support, which inherits all glob patterns from the files.exclude setting.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: this package is manually tested
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: This package has no e2e tests
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: No feature change

Copy link

changeset-bot bot commented Aug 21, 2024

🦋 Changeset detected

Latest commit: 796b8f6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@cloudflare/quick-edit Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 21, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-wrangler-6546

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6546/npm-package-wrangler-6546

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-wrangler-6546 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-create-cloudflare-6546 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-kv-asset-handler-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-miniflare-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-pages-shared-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-vitest-pool-workers-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-workers-editor-shared-6546
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10666768168/npm-package-cloudflare-workers-shared-6546

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240821.0
workerd 1.20240821.1 1.20240821.1
workerd --version 1.20240821.1 2024-08-21

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@edmundhung edmundhung force-pushed the edmundhung/quick-edit-hidden-files branch 2 times, most recently from db7c462 to 2dc09ca Compare August 21, 2024 14:21
@edmundhung edmundhung marked this pull request as ready for review August 21, 2024 14:30
@edmundhung edmundhung requested a review from a team as a code owner August 21, 2024 14:30
Copy link
Contributor

@penalosa penalosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

packages/quick-edit-extension/src/cfs.ts Outdated Show resolved Hide resolved
packages/quick-edit-extension/src/cfs.ts Outdated Show resolved Hide resolved
packages/quick-edit/functions/_middleware.ts Outdated Show resolved Hide resolved
@edmundhung edmundhung force-pushed the edmundhung/quick-edit-hidden-files branch from ff46d68 to 796b8f6 Compare September 2, 2024 12:04
@edmundhung edmundhung merged commit addb210 into main Sep 9, 2024
21 checks passed
@edmundhung edmundhung deleted the edmundhung/quick-edit-hidden-files branch September 9, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants