Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add workers-shared override in vitest-pool-workers global setup #6505

Merged
merged 1 commit into from
Aug 15, 2024

Conversation

CarmenPopoviciu
Copy link
Contributor

@CarmenPopoviciu CarmenPopoviciu commented Aug 15, 2024

What this PR solves / how to test

vitest-pool-workers tests are failing on #6490 due to 👇

Screenshot 2024-08-15 at 17 56 10

This is caused by that fact in that PR, the workers-shared version was bumped to 0.2.0, and vitest-pool-workers is trying to pull that package version from the registry.

This PR fixes the above issue, by having vitest-pool-workers use a local tarball of workers-shared, just like it does for miniflare, wrangler, etc.

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because: existing tests should be sufficient
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: internal change
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because: internal change
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because: internal change

@CarmenPopoviciu CarmenPopoviciu requested a review from a team as a code owner August 15, 2024 16:15
Copy link

changeset-bot bot commented Aug 15, 2024

⚠️ No Changeset found

Latest commit: bfe6bfe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Aug 15, 2024

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407098151/npm-package-wrangler-6505

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6505/npm-package-wrangler-6505

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407098151/npm-package-wrangler-6505 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407098151/npm-package-create-cloudflare-6505 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407098151/npm-package-cloudflare-kv-asset-handler-6505
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407098151/npm-package-miniflare-6505
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407098151/npm-package-cloudflare-pages-shared-6505
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407098151/npm-package-cloudflare-vitest-pool-workers-6505
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407098151/npm-package-cloudflare-workers-editor-shared-6505
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10407098151/npm-package-cloudflare-workers-shared-6505

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240806.0
workerd 1.20240806.0 1.20240806.0
workerd --version 1.20240806.0 2024-08-06

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

@CarmenPopoviciu CarmenPopoviciu merged commit 371b6bb into main Aug 15, 2024
35 checks passed
@CarmenPopoviciu CarmenPopoviciu deleted the carmen/fix-tests branch August 15, 2024 20:10
@emily-shen emily-shen mentioned this pull request Oct 23, 2024
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants