Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try improve fixture flakiness due to unstable_dev #6367

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

RamIdeas
Copy link
Contributor

@RamIdeas RamIdeas commented Jul 29, 2024

What this PR solves / how to test

This PR includes changes to fixture tests (notoriously flakey fixtures: get-platform-proxy, local-mode-tests) to make them more stable, including:

  • use fileBasedRegistry: true in get-platform-proxy (hypothesis: only flakey because of the dev registry)
  • use port: 0 in local-mode-tests module.test.ts
  • ensure unstable_dev cleans up local-mode-tests logging.test.ts (which expects it to fail – this may have affected other tests running after)

Author has addressed the following

  • Tests
    • TODO (before merge)
    • Included
    • Not necessary because:
  • E2E Tests CI Job required? (Use "e2e" label or ask maintainer to run separately)
    • I don't know
    • Required / Maybe required
    • Not required because: fixture tests exist for unstable_dev
  • Changeset (Changeset guidelines)
    • TODO (before merge)
    • Included
    • Not necessary because:
  • Public documentation
    • TODO (before merge)
    • Cloudflare docs PR(s):
    • Not necessary because:

@RamIdeas RamIdeas requested a review from a team as a code owner July 29, 2024 18:50
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 8097d92

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
wrangler Patch
@cloudflare/vitest-pool-workers Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@RamIdeas RamIdeas changed the title try improve fixture flakiness try improve fixture flakiness due to unstable_dev Jul 29, 2024
Copy link
Contributor

A wrangler prerelease is available for testing. You can install this latest build in your project with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10150080453/npm-package-wrangler-6367

You can reference the automatically updated head of this PR with:

npm install --save-dev https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/prs/6367/npm-package-wrangler-6367

Or you can use npx with this latest build directly:

npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10150080453/npm-package-wrangler-6367 dev path/to/script.js
Additional artifacts:
npx https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10150080453/npm-package-create-cloudflare-6367 --no-auto-update
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10150080453/npm-package-cloudflare-kv-asset-handler-6367
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10150080453/npm-package-miniflare-6367
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10150080453/npm-package-cloudflare-pages-shared-6367
npm install https://prerelease-registry.devprod.cloudflare.dev/workers-sdk/runs/10150080453/npm-package-cloudflare-vitest-pool-workers-6367

Note that these links will no longer work once the GitHub Actions artifact expires.


[email protected] includes the following runtime dependencies:

Package Constraint Resolved
miniflare workspace:* 3.20240718.1
workerd 1.20240718.0 1.20240718.0
workerd --version 1.20240718.0 2024-07-18

Please ensure constraints are pinned, and miniflare/workerd minor versions match.

Copy link
Contributor

@petebacondarwin petebacondarwin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's suck it and see!

@petebacondarwin
Copy link
Contributor

The fixture tests immediately then flake on a new fixture: external-durable-objects-app 😆

@petebacondarwin petebacondarwin merged commit 7588800 into main Jul 29, 2024
18 checks passed
@petebacondarwin petebacondarwin deleted the fixtures-flakiness branch July 29, 2024 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants